In file included from /data/jenkins/workspace/firefox-clang-last/obj-x86_64-pc-linux-gnu/netwerk/protocol/device/Unified_cpp_protocol_device0.cpp:2: /data/jenkins/workspace/firefox-clang-last/netwerk/protocol/device/nsDeviceChannel.cpp:80:28: error: unused variable 'width' [-Werror,-Wunused-variable] NS_NAMED_LITERAL_CSTRING(width, "width="); ^ /data/jenkins/workspace/firefox-clang-last/netwerk/protocol/device/nsDeviceChannel.cpp:81:28: error: unused variable 'height' [-Werror,-Wunused-variable] NS_NAMED_LITERAL_CSTRING(height, "height="); ^ This is because clang improved its detection of unused variables: https://reviews.llvm.org/D38678

Is moz-device protocol still in used? It is introduce to access android camera stream, but nowadays we have GetUserMedia API for this purpose. We can remove the entire folder if necessary.

Comment on attachment 8918649 [details] Bug 1408751 - nsDeviceChannel::OpenContentStream: remove unused variable 'width' & 'height' https://reviewboard.mozilla.org/r/189478/#review194788

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #2) > Is moz-device protocol still in used? It is introduce to access android > camera stream, but nowadays we have GetUserMedia API for this purpose. We > can remove the entire folder if necessary. It seems so, but we should double check with the channel consumer (media team, ui?) and open another bug.

ok, thanks, I will take care of that (I have a build without this directory)

Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/78e4e2c9f11f nsDeviceChannel::OpenContentStream: remove unused variable 'width' & 'height' r=dragana